wu-sheng commented on a change in pull request #4337: Review code styles
automatically
URL: https://github.com/apache/skywalking/pull/4337#discussion_r376785914
##########
File path: apm-checkstyle/checkStyle.xml
##########
@@ -20,19 +20,27 @@
<!DOCTYPE module PUBLIC
"-//Puppy Crawl//DTD Check Configuration 1.3//EN"
"http://checkstyle.org/dtds/configuration_1_3.dtd";>
-<!--Refer
http://checkstyle.sourceforge.net/reports/google-java-style.html#s2.2-file-encoding
-->
<module name="Checker">
<property name="localeLanguage" value="en"/>
- <!--To configure the check to report on the first instance in each file-->
- <module name="FileTabCharacter"/>
+ <module name="FileTabCharacter">
+ <property name="eachLine" value="true"/>
+ </module>
<module name="RegexpSingleline">
<property name="format" value="System\.out\.println"/>
<property name="message" value="Prohibit invoking System.out.println
in source code !"/>
</module>
+ <module name="RegexpSingleline">
+ <property name="severity" value="warning"/>
Review comment:
Why this is warning? I think we should remove them? (Existing @author)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
