wu-sheng commented on issue #4228: Support Browser protocol at OAP
URL: https://github.com/apache/skywalking/pull/4228#issuecomment-584992794
 
 
   > For PV with JS error in specified time, If server can't know which errors 
belong to which PV now, we can add a parameter to mark in error logs. After 
this, PV with JS error will be calculate. I think it is easy to calculate total 
PV in specified time.
   
   Theoretically, it could help the calculation, but in engineering practice, 
it can't. No matter which parameter(or ID) you gave the error log, the backend 
can't cache/persistent the context. It will be easy to crash the backend as 
endless memory requirements. Also, you should know, the backend is in the 
cluster mode, as millions of browser could be opened at the same time, every 
time you report the data, there is one or multiple Gateways(LBs) to forward the 
data to a random OAP cluster node, which may or may not have the 
context(cached) even we could afford the memory. 
   
   Only solution I could have is, the client knows this is the first report or 
further report for every page, we could add a flag in the log report protocol 
to indicate this. Then the PV with error is only calculated when this new 
flag(isFirstPageErrorReport) is true.
   
   WDYT? @Fine0830 @arugal 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to