wu-sheng commented on a change in pull request #2: doc: emphasize that the
finish should be called only when the output …
URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383315487
##########
File path: README.md
##########
@@ -48,7 +48,9 @@ http {
proxy_pass http://127.0.0.1:8080/backend;
body_filter_by_lua_block {
- require("tracer"):finish()
+ if ngx.eof then
Review comment:
@spacewander Could you apply this change to
https://github.com/apache/skywalking-nginx-lua/blob/master/examples/nginx.conf#L78
too?
That file is for local closed-loop test, it makes the dev team doesn't
require the SkyWalking backend.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
