spacewander commented on a change in pull request #2: doc: emphasize that the
finish should be called only when the output …
URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383666410
##########
File path: README.md
##########
@@ -48,7 +48,9 @@ http {
proxy_pass http://127.0.0.1:8080/backend;
body_filter_by_lua_block {
- require("tracer"):finish()
+ if ngx.eof then
Review comment:
@wu-sheng
`ngx.eof` is a function which marks the end of the body, but not the mark.
In `body_filter_by_lua*` phase, the `ngx.arg[1]` returns the body data and
`ngx.arg[2]` returns the mark itself (a metamethod is called under the hover).
So in my previous commit, use `ngx.eof` (a function) is incorrect,
`ngx.arg[2]`(the mark) should be used instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
