Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449754663
##########
File path:
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsTransWorker.java
##########
@@ -36,28 +32,12 @@
private final MetricsPersistentWorker hourPersistenceWorker;
private final MetricsPersistentWorker dayPersistenceWorker;
- private final CounterMetrics aggregationHourCounter;
- private final CounterMetrics aggregationDayCounter;
-
public MetricsTransWorker(ModuleDefineHolder moduleDefineHolder,
- String modelName,
MetricsPersistentWorker hourPersistenceWorker,
MetricsPersistentWorker dayPersistenceWorker) {
super(moduleDefineHolder);
this.hourPersistenceWorker = hourPersistenceWorker;
this.dayPersistenceWorker = dayPersistenceWorker;
-
- MetricsCreator metricsCreator =
moduleDefineHolder.find(TelemetryModule.NAME)
- .provider()
-
.getService(MetricsCreator.class);
- aggregationHourCounter = metricsCreator.createCounter(
- "metrics_aggregation", "The number of rows in aggregation", new
MetricsTag.Keys("metricName", "level",
-
"dimensionality"
- ), new MetricsTag.Values(modelName, "2", "hour"));
- aggregationDayCounter = metricsCreator.createCounter(
Review comment:
I didn't remove it. I used model.getDownsampling().getName() in
MetricsPersistentWorker class.
The metrics of minutes,hours and days can be exposed.
```
aggregationCounter = metricsCreator.createCounter(
"metrics_aggregation", "The number of rows in aggregation",
new MetricsTag.Keys("metricName", "level",
"dimensionality"), new MetricsTag.Values(model.getName(), "2",
model.getDownsampling().getName())
);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
