[GitHub] [skywalking] Ax1an commented on a change in pull request #5028: Fix no data bug of oap self observability instance_metrics_second_aggregation metrics.

Sat, 04 Jul 2020 03:51:47 -0700 


Ax1an commented on a change in pull request #5028:
URL: https://github.com/apache/skywalking/pull/5028#discussion_r449762490



##########
File path: 
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsAggregateWorker.java
##########
@@ -69,7 +69,7 @@
                                                           
.getService(MetricsCreator.class);
         aggregationCounter = metricsCreator.createCounter(
             "metrics_aggregation", "The number of rows in aggregation",
-            new MetricsTag.Keys("metricName", "level", "dimensionality"), new 
MetricsTag.Values(modelName, "1", "min")
+            new MetricsTag.Keys("metricName", "level", "dimensionality"), new 
MetricsTag.Values(modelName, "1", "minute")

Review comment:
       From my perspective, minute is better than min. Because DownSampling 
enum is minute.
   I prefer to adjust grafana.json.
   
![image](https://user-images.githubusercontent.com/28091237/86510869-6160f400-be26-11ea-9e17-38b8d8e99d0f.png)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to