lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473647252
##########
File path:
apm-sniffer/apm-agent/src/main/java/org/apache/skywalking/apm/agent/SkyWalkingAgent.java
##########
@@ -203,4 +213,25 @@ public void onError(final String typeName,
public void onComplete(String typeName, ClassLoader classLoader,
JavaModule module, boolean loaded) {
}
}
+
+ static void configureLogger() {
Review comment:
> The variable should not be injected through the way you did.
Well. I remove this static block and first init config as it previously did.
Then I reconfigure the `Logger` after config initialization finishes.
The procedure now completely follows the rules except the first few log
calls in `SnifferConfigInitializer` will still use the default logger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
