wu-sheng commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473655618
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java
##########
@@ -207,4 +212,15 @@ private static InputStreamReader loadConfig() throws
AgentPackageNotFoundExcepti
}
throw new ConfigNotFoundException("Failed to load agent.config.");
}
+
+ static void configureLogger() {
Review comment:
This is not a good way to do this switch. I am waiting for the PMC
confirmation about whether JSON format is acceptable. If YES, we need to
improve this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
