lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473806164
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/Converter.java
##########
@@ -19,10 +19,13 @@
package org.apache.skywalking.apm.agent.core.logging.core;
/**
- * The Converter, It is used to convert the LogEvent to the String.
+ * The Converter, it is used to convert the LogEvent to the String.
*/
public interface Converter {
String convert(LogEvent logEvent);
+ default String getKey() {
Review comment:
> Once you add this, why need a default implementation?
We don't need to implement `getKey()` for `LiteralConverter`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
