lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r473808659
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/Config.java
##########
@@ -259,6 +260,43 @@
* @see
org.apache.skywalking.apm.agent.core.logging.core.PatternLogger#DEFAULT_CONVERTER_MAP
*/
public static String PATTERN = "%level %timestamp %thread %class :
%msg %throwable";
+
+ public static class JSON {
+ /**
+ * Key of the AgentName
+ */
+ public static String AGENT_NAME_KEY = "agent_name";
Review comment:
> Technically, yes, my question is more about, why and who will config
this.
The application developer can config this provided that they use a different
json key set for their application. So unification of these keys may be
necessary for them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
