lujiajing1126 commented on pull request #5357: URL: https://github.com/apache/skywalking/pull/5357#issuecomment-680672257
> @lujiajing1126 so the problem now is that even you configure the format to JSON, some (at the beginning) of the logs are still pattern-based until the config is actually initialized (that the logger manger can determine which format to use), it's kind of circular dependency here Yes, exactly. But I suppose the problem only exists in `SnifferConfigInitializer`, specifically this part, https://github.com/apache/skywalking/blob/77d94b4d2a906cf160cfab28fd8a045ec2a2ce1d/apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/conf/SnifferConfigInitializer.java#L62-L90 What about postponing log output in this class? For example, push the logs into a queue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
