lujiajing1126 commented on pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#issuecomment-683294403


   > Another recommendation, could you enhance `PatternLoggerTest` and 
`JsonLoggerTest` to check the print texts, rather than times. Because since 
this PR merged, the format could have a bug in theory.
   
   I have refactored the test codes to impose stricter tests. CI seems to be 
fine so far.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to