lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r479622104
##########
File path: pom.xml
##########
@@ -581,6 +588,7 @@
</resourceExcludes>
<excludes>
**/target/generated-test-sources/**,
+
org/apache/skywalking/apm/agent/core/logging/core/generated/LoggingBenchmark*.java,
Review comment:
> But why that benchmark doesn't generate anything? That is why I am
asking the question.
I am not clear about what happened in the past. I guess it was a trick to
avoid the style-check issue. But I am sure the dependency should have been
declared there.
I am still curious why you can run it seamlessly?
As I understand, this LOC should help, but actually not
https://github.com/apache/skywalking/blob/cbb2e1793bbe55c566134d06c70fd2fefb1ecaa4/pom.xml#L583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
