lujiajing1126 commented on a change in pull request #5357:
URL: https://github.com/apache/skywalking/pull/5357#discussion_r479625996
##########
File path: pom.xml
##########
@@ -290,6 +291,12 @@
<version>${powermock.version}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.openjdk.jmh</groupId>
+ <artifactId>jmh-generator-annprocess</artifactId>
+ <version>${jmh.version}</version>
+ <scope>test</scope>
+ </dependency>
Review comment:
> I mean you should, my local IDE may be set differently, but as you are
adding this, we should make sure this is added in all necessary places.
I have added this dependency to all necessary modules to ensure those
benchmarks can be run locally.
Also two general exclude rules are introduced to exclude all jmh generated
classes.
```
**/generated/*_jmhType*.java,
**/generated/*_jmhTest.java
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
