EvanLjp commented on pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#issuecomment-688860449
Grpc plugin test also has some error.
Some codes in grpc agent plugin:
```
org.apache.skywalking.apm.plugin.grpc.v1.client.TracingClientCall#cancel
public void cancel(@Nullable String message, @Nullable Throwable cause) {
final AbstractSpan span =
ContextManager.createLocalSpan(operationPrefix +
REQUEST_ON_CANCEL_OPERATION_NAME);
span.setComponent(ComponentsDefine.GRPC);
span.setLayer(SpanLayer.RPC_FRAMEWORK);
ContextManager.continued(snapshot);
if (cause != null) {
span.log(cause);
}
try {
super.cancel(message, cause);
} catch (Throwable t) {
ContextManager.activeSpan().log(t);
throw t;
} finally {
ContextManager.stopSpan();
}
}
```
The author creates a local span to store error status when canceling.
Because only log the exception, the before status should always is a normal
span. But the status will be error now. I think this situation can be ignored.
After all, OAP can determine the status based on Entry Span only. What do u
think?
@wu-sheng
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
