EvanLjp commented on pull request #5426:
URL: https://github.com/apache/skywalking/pull/5426#issuecomment-688921681
> From my understanding, in default,
`ContextManager.activeSpan().errorOccurred().log(t);` ==
`ContextManager.activeSpan().log(t);`, isn't it?
The code in grpc plugin is like following:
```
AbstractSpan span = ContextManager.createLocalSpan(operationPrefix +
REQUEST_ON_CANCEL_OPERATION_NAME);
if (cause != null) {
span.log(cause);
}
```
Before : the status of the local span is always false.
Now: the status of the local span is always true.
The question I want to ask is can we ignore this situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
