wu-sheng commented on a change in pull request #5510:
URL: https://github.com/apache/skywalking/pull/5510#discussion_r490685991
##########
File path:
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/ProducerConstructorMapInterceptor.java
##########
@@ -22,16 +22,27 @@
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
import org.apache.skywalking.apm.util.StringUtil;
+import java.util.List;
import java.util.Map;
+import java.util.regex.Pattern;
+/**
+ * Target at kafka-clients 2.1+
+ */
Review comment:
You didn't add any new instrumentation definition. So, this must be
compatible with older releases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
