lujiajing1126 commented on a change in pull request #5510:
URL: https://github.com/apache/skywalking/pull/5510#discussion_r490686334
##########
File path:
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/ProducerConstructorMapInterceptor.java
##########
@@ -22,16 +22,27 @@
import
org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor;
import org.apache.skywalking.apm.util.StringUtil;
+import java.util.List;
import java.util.Map;
+import java.util.regex.Pattern;
+/**
+ * Target at kafka-clients 2.1+
+ */
Review comment:
> But this interceptor still supports `String` as a parameter, I still
can see the String casting.
Exactly. Regarding `bootstrap.servers`, the type of the value in the map can
be `String` or `List`. Both types are supported by kafka client lib.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
