lujiajing1126 commented on issue #5494:
URL: https://github.com/apache/skywalking/issues/5494#issuecomment-696475250


   > > I suppose so far the micrometer plugin is only available for the 
application.
   > 
   > Don't know what this means. @lujiajing1126
   
   I understand the micrometer support can be introduced by including 
`apm-toolkit-micrometer-registry` as a dependency in the service. And this 
requires manual work which is documented here 
https://github.com/apache/skywalking/blob/master/docs/en/setup/service-agent/java-agent/Application-toolkit-micrometer.md
   
   But I am wondering if it is possible to support micrometer in the core part. 
So we can adapt a collection of `MeterBinder` provided by the community of 
micrometer. For instance 
[KafkaClientMetrics](https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/kafka/KafkaClientMetrics.java),
 we can use it directly in the constructor interceptor of `KafkaProducer` and 
`KafkaConsumer` which thus does not need any manual code in the application.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to