lujiajing1126 commented on issue #5494: URL: https://github.com/apache/skywalking/issues/5494#issuecomment-696496289
> This is very dangerous to do the integration. Use a 3rd party APIs and its implementation in the agent core would face the class loader issue. You should have noticed, we never introduce any other libs in the agent, unless the agent core uses itself, and it would be shaded in another package name to avoid conflict. Yes. I fully understood this concern. But also I believe as long as we shade the library and all its dependencies, that would not be a problem. We have developed some other agent which includes `micrometer` in the agent, of course with package shades. Everything works well except that we cannot talk to this kind of API from the application with any shaded class which is a known caveat. > From my understanding of the micrometer system, KafkaClientMetrics is at the instrumentation side, once you activated that, and also activated the SkyWalking register, the metrics will flow into agent core directly. Have you tested? Anyway, we will have an investigation first. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
