EvanLjp edited a comment on pull request #5571: URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699852596
> This will make duplicated injection for every segment. I prefer we don't do this. You are making this similar to OpenTracing Baggage, which we didn't plan to support when we disigned the correlation context. > > Also, every new feature should be discussed before changing im case to avoid argument after you have finished the prototype codes. Do you have any other ideas? This PR comes from support for online flow pressure measurement. 1. At the moment, correlation is just propagation. 2. The current requirement is that sometimes need to inject span. 3. some usages are online traffic staining and tenant traffic discrimination. Another idea to ensure safety : we only support inject tags name by external passing to label the traffic source. the passing value: sw-correlation: base64(tagName):base64(token) The tagName must be configured in the agent.conf. Or we only support hard code k:v config propagate ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
