EvanLjp removed a comment on pull request #5571: URL: https://github.com/apache/skywalking/pull/5571#issuecomment-699961399
> The key issue is, injecting this has high-security and memory/network/backend overload concerns. We should carefully reconsider how to do this. Personally, I still prefer an API or a pure optional plugin. The key point is, asking users to activate this manually, then we could set up documentation with it to tell users, note the security issue. @wu-sheng there are some ideas about supporting it in an optional way. step 1: refactor some codes of the span behavior: 1. define a new span callback interface for service loader 2. define a span filter chain to process span behavior, such as extract for the carrier or inject to carrier 3. the order of the span filter chain triggered is ordered by the number of callback interfaces. step 2: supports correlation behavior by filter chain: 1. the default correlation behavior is only propagate 2. the optional behavior will add an injection behavior, the code way is to add a filter rather than override to ensure the stability of the main process. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
