wu-sheng commented on a change in pull request #5628:
URL: https://github.com/apache/skywalking/pull/5628#discussion_r499239199
##########
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
##########
@@ -203,4 +206,25 @@ private void readCompositeRuleConfig(Rules rules) {
}
});
}
+
+ /**
+ * Read composite rule config into {@link DingtalkSettings}
+ */
+ private void readDingtalkConfig(Rules rules) {
Review comment:
Please recheck the test case, seems this method is not covered. Also,
please help on rechecking other `read*` methods in this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
