xbkaishui commented on a change in pull request #5628:
URL: https://github.com/apache/skywalking/pull/5628#discussion_r499240884
##########
File path:
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RulesReader.java
##########
@@ -203,4 +206,25 @@ private void readCompositeRuleConfig(Rules rules) {
}
});
}
+
+ /**
+ * Read composite rule config into {@link DingtalkSettings}
+ */
+ private void readDingtalkConfig(Rules rules) {
Review comment:
Actually I have added test logic in RulesReaderTest.java will check
others. it may be related to Codecov detect logic. let me check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
