wu-sheng commented on a change in pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#discussion_r516450746
##########
File path:
oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig
podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer =
factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE,
params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE,
params.resourceVersion, 300,
Review comment:
300 seconds? I am a little confused.
##########
File path:
oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig
podConfig) throws
SharedIndexInformer<V1Pod> podSharedIndexInformer =
factory.sharedIndexInformerFor(
params -> coreV1Api.listNamespacedPodCall(
podConfig.getNamespace(), null, null, null, null,
- podConfig.getLabelSelector(), Integer.MAX_VALUE,
params.resourceVersion, params.timeoutSeconds,
+ podConfig.getLabelSelector(), Integer.MAX_VALUE,
params.resourceVersion, 300,
Review comment:
OK, got it now. Could you submit an issue to track this?
I think we need to upgrade the client to 10.1(maybe? the Last release is
10.0 already), and change this back to the right way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
