[GitHub] [skywalking] EvanLjp commented on a change in pull request #5777: Fixed unit of time mixing problem in kubernetes-client

Tue, 03 Nov 2020 06:14:48 -0800 


EvanLjp commented on a change in pull request #5777:
URL: https://github.com/apache/skywalking/pull/5777#discussion_r516451461



##########
File path: 
oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig 
podConfig) throws
         SharedIndexInformer<V1Pod> podSharedIndexInformer = 
factory.sharedIndexInformerFor(
             params -> coreV1Api.listNamespacedPodCall(
                 podConfig.getNamespace(), null, null, null, null,
-                podConfig.getLabelSelector(), Integer.MAX_VALUE, 
params.resourceVersion, params.timeoutSeconds,
+                podConfig.getLabelSelector(), Integer.MAX_VALUE, 
params.resourceVersion, 300,

Review comment:
       
![image](https://user-images.githubusercontent.com/31562192/97956001-8b312400-1de2-11eb-98b8-44d0ee09fb66.png)
   Follow the Kubernetes default configuration

##########
File path: 
oap-server/server-cluster-plugin/cluster-kubernetes-plugin/src/main/java/org/apache/skywalking/oap/server/cluster/plugin/kubernetes/NamespacedPodListInformer.java
##########
@@ -83,7 +83,7 @@ private void doStartPodInformer(ClusterModuleKubernetesConfig 
podConfig) throws
         SharedIndexInformer<V1Pod> podSharedIndexInformer = 
factory.sharedIndexInformerFor(
             params -> coreV1Api.listNamespacedPodCall(
                 podConfig.getNamespace(), null, null, null, null,
-                podConfig.getLabelSelector(), Integer.MAX_VALUE, 
params.resourceVersion, params.timeoutSeconds,
+                podConfig.getLabelSelector(), Integer.MAX_VALUE, 
params.resourceVersion, 300,

Review comment:
       https://github.com/apache/skywalking/issues/5778




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to