jdyer1 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1415702842


##########
apps/showcase/pom.xml:
##########
@@ -145,6 +146,48 @@
 
     <build>
         <plugins>
+            <plugin>
+              <groupId>org.apache.maven.plugins</groupId>
+              <artifactId>maven-dependency-plugin</artifactId>
+              <executions>
+                <execution>
+                  <?m2e ignore?>
+                  <id>copy-dependencies</id>
+                  <phase>package</phase>
+                  <goals>
+                    <goal>copy</goal>

Review Comment:
   @kusalk  I struggled when doing this to figure out how the 
jetty-maven-plugin was building its classpath.  It was not including the 4 jars 
we generate from the Eclipse Transformer, so the showcase integration tests all 
would fail.  The solution I found was to use the Jetty "extraclasspath" feature 
(see same pom.xml lines 236ff) in conjunction with copying the jars as you see 
here.  In my ignorance I may have passed up a more-elegant solution!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to