sepe81 commented on code in PR #778:
URL: https://github.com/apache/struts/pull/778#discussion_r1427104760


##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.java:
##########
@@ -72,16 +73,16 @@ public void parse(HttpServletRequest request, String 
saveDir) throws IOException
         } catch (FileUploadException e) {
             LOG.debug("Request exceeded size limit!", e);
             LocalizedMessage errorMessage;
-            if (e instanceof FileUploadBase.SizeLimitExceededException) {
-                FileUploadBase.SizeLimitExceededException ex = 
(FileUploadBase.SizeLimitExceededException) e;
-                errorMessage = buildErrorMessage(e, new 
Object[]{ex.getPermittedSize(), ex.getActualSize()});
-            } else if (e instanceof 
FileUploadBase.FileSizeLimitExceededException) {
-                FileUploadBase.FileSizeLimitExceededException ex = 
(FileUploadBase.FileSizeLimitExceededException) e;
-                errorMessage = buildErrorMessage(e, new 
Object[]{ex.getFileName(), ex.getPermittedSize(), ex.getActualSize()});
-            } else if (e instanceof FileCountLimitExceededException) {
-                FileCountLimitExceededException ex = 
(FileCountLimitExceededException) e;
-                errorMessage = buildErrorMessage(e, new 
Object[]{ex.getLimit()});
-            } else {
+            if (e instanceof FileUploadByteCountLimitException) {
+                FileUploadByteCountLimitException ex = 
(FileUploadByteCountLimitException) e;
+                errorMessage = buildErrorMessage(e, new 
Object[]{ex.getFileName(), ex.getPermitted(), ex.getActualSize()});
+            } else if (e instanceof FileUploadFileCountLimitException) {
+                FileUploadFileCountLimitException ex = 
(FileUploadFileCountLimitException) e;
+                errorMessage = buildErrorMessage(e, new 
Object[]{ex.getPermitted()});
+            } else if (e instanceof FileUploadSizeException) {
+                FileUploadSizeException ex = (FileUploadSizeException) e;
+                errorMessage = buildErrorMessage(e, new 
Object[]{ex.getPermitted(), ex.getActualSize()});
+            }   else {

Review Comment:
   ```suggestion
               } else {
   ```
   
   revert indentation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to