kusalk commented on code in PR #979:
URL: https://github.com/apache/struts/pull/979#discussion_r1668291315
##########
core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java:
##########
@@ -1284,12 +1295,11 @@ public void testAvoidCallingMethodsWithBraces() {
assertEquals(expected.getMessage(), "Inappropriate OGNL expression:
toString()");
}
- public void testAvoidCallingSomeClasses() {
+ public void testStaticMethodBlocked() {
Foo foo = new Foo();
Exception expected = null;
try {
- ognlUtil.setExcludedClasses(Runtime.class.getName());
Review Comment:
The exclusion list isn't checked here as it's already blocked by the static
method check
##########
core/src/test/java/com/opensymphony/xwork2/ognl/OgnlUtilTest.java:
##########
@@ -1166,9 +1171,11 @@ public void testAvoidCallingMethodsOnObjectClass() {
public void testAllowCallingMethodsOnObjectClassInDevModeTrue() {
Exception expected = null;
try {
- ognlUtil.setExcludedClasses(Foo.class.getName());
Review Comment:
These methods don't do anything, so we inject the configuration instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
