kusalk commented on code in PR #979:
URL: https://github.com/apache/struts/pull/979#discussion_r1668289815
##########
core/src/main/java/com/opensymphony/xwork2/ognl/SecurityMemberAccess.java:
##########
@@ -460,4 +473,41 @@ public void useDisallowProxyMemberAccess(String
disallowProxyMemberAccess) {
public void useDisallowDefaultPackageAccess(String
disallowDefaultPackageAccess) {
this.disallowDefaultPackageAccess =
BooleanUtils.toBoolean(disallowDefaultPackageAccess);
}
+
+ @Inject(StrutsConstants.STRUTS_DEVMODE)
+ protected void useDevMode(String devMode) {
+ this.isDevMode = BooleanUtils.toBoolean(devMode);
+ }
+
+ @Inject(value = StrutsConstants.STRUTS_DEV_MODE_EXCLUDED_CLASSES, required
= false)
+ public void useDevModeExcludedClasses(String commaDelimitedClasses) {
+ this.devModeExcludedClasses = toNewClassesSet(devModeExcludedClasses,
commaDelimitedClasses);
+ }
+
+ @Inject(value =
StrutsConstants.STRUTS_DEV_MODE_EXCLUDED_PACKAGE_NAME_PATTERNS, required =
false)
+ public void useDevModeExcludedPackageNamePatterns(String
commaDelimitedPackagePatterns) {
+ this.devModeExcludedPackageNamePatterns =
toNewPatternsSet(devModeExcludedPackageNamePatterns,
commaDelimitedPackagePatterns);
+ }
+
+ @Inject(value = StrutsConstants.STRUTS_DEV_MODE_EXCLUDED_PACKAGE_NAMES,
required = false)
+ public void useDevModeExcludedPackageNames(String
commaDelimitedPackageNames) {
+ this.devModeExcludedPackageNames =
toNewPackageNamesSet(devModeExcludedPackageNames, commaDelimitedPackageNames);
+ }
+
+ @Inject(value =
StrutsConstants.STRUTS_DEV_MODE_EXCLUDED_PACKAGE_EXEMPT_CLASSES, required =
false)
+ public void useDevModeExcludedPackageExemptClasses(String
commaDelimitedClasses) {
+ this.devModeExcludedPackageExemptClasses =
toClassesSet(commaDelimitedClasses);
+ }
+
+ private void useDevModeConfiguration() {
+ if (!isDevMode || isDevModeInit) {
Review Comment:
The `isDevModeInit` check isn't thread-safe but it doesn't need to be as
there's no negative consequence of running this method more than once when
DevMode is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
