hughhhh commented on a change in pull request #4871: Add spider/radar chart
URL:
https://github.com/apache/incubator-superset/pull/4871#discussion_r186556869
##########
File path: superset/viz.py
##########
@@ -2375,6 +2375,35 @@ def get_data(self, df):
return result
+class SpiderRadarViz(BaseViz):
+ """
+ A spider / radar chart.
+ """
+
+ viz_type = 'spider_radar'
+ verbose_name = _('Spider Radar Diagram')
+ credits = (
+ '<a href=https://www.visualcinnamon.com/>Nadieh Bremer, Data Viz
Expert</a>')
+ is_timeseries = False
+
+ def get_data(self, df):
Review comment:
I was specifically talking about python unit test. So to add test for these
codeblocks you would reference this file.
https://github.com/hughhhh/incubator-superset/blob/master/tests/viz_tests.py
I would recommend adding some mock data as a fixture to help test out how
the methods should react with certain dataframes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
