williaster commented on a change in pull request #4962: Markdown for dashboard
URL:
https://github.com/apache/incubator-superset/pull/4962#discussion_r186935568
##########
File path: superset/assets/src/dashboard/components/BuilderComponentPane.jsx
##########
@@ -67,18 +74,13 @@ class BuilderComponentPane extends React.PureComponent {
<i className="fa fa-arrow-right trigger" />
</div>
- <div className="dashboard-builder-sidepane-header">
- {t('Containers')}
- </div>
<NewTabs />
<NewRow />
<NewColumn />
- <div className="dashboard-builder-sidepane-header">
- {t('More components')}
- </div>
<NewHeader />
<NewDivider />
+ <NewMarkdown />
Review comment:
I think this probably makes most sense below header.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
