williaster commented on a change in pull request #4962: Markdown for dashboard
URL:
https://github.com/apache/incubator-superset/pull/4962#discussion_r187423026
##########
File path: superset/assets/src/dashboard/reducers/getInitialState.js
##########
@@ -74,26 +74,28 @@ export default function(bootstrapData) {
const sliceIds = new Set();
dashboard.slices.forEach(slice => {
const key = slice.slice_id;
- chartQueries[key] = {
- ...chart,
- id: key,
- form_data: slice.form_data,
- formData: applyDefaultFormData(slice.form_data),
- };
+ if (['separator', 'markup'].indexOf(slice.form_data.viz_type) === -1) {
+ chartQueries[key] = {
+ ...chart,
+ id: key,
+ form_data: slice.form_data,
+ formData: applyDefaultFormData(slice.form_data),
Review comment:
🙉 that is the worst naming ever! why not call it form_data_with_filters?!
but yeah, sounds like we can't change it now. thanks for the deets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
