[GitHub] graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove from error message

[GitBox]

graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove 
<br> from error message
URL: 
https://github.com/apache/incubator-superset/pull/4900#issuecomment-389617808
 
 
   @jasnovak @mistercrunch If user doesn't have save access to dashboard, we 
used to allow user `save-as` a new copy of this dashboard ( and allow copy all 
slices under current dashboard). 
   With this PR, user can't save-as another dashboard anymore. Is this intended 
behavior?
   
   before:
   <img width="1139" alt="screen_shot_2018-05-16_at_11_12_01_am-2" 
src="https://user-images.githubusercontent.com/27990562/40135870-37ad10fe-58fb-11e8-9e6c-d21738246f7a.png";>
   
   after:
   <img width="1146" alt="screen shot 2018-05-16 at 11 09 34 am" 
src="https://user-images.githubusercontent.com/27990562/40136272-41b3deb0-58fc-11e8-8869-083a113eea22.png";>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org