graceguo-supercat commented on issue #4900: Hide restricted ui elements, remove 
<br> from error message
URL: 
https://github.com/apache/incubator-superset/pull/4900#issuecomment-390806736
 
 
   @jasnovak In Superset build-in 
[roles](https://superset.apache.org/security.html#provided-roles): both Alpha 
user and Gamma user can save dashboard, and can save other owner's dashboard as 
their copy. [There are tests to assure this 
feature](https://github.com/apache/incubator-superset/blob/7f1d7543d05cedf5b5725b6da81943bd551ccc87/tests/security_tests.py#L48).
 We have a lot of users want to copy other's dashboard, but not change the 
original one. But with this PR, all Alpha and Gamma users can't save copy 
anymore.
   
   I want to make some changes that still allow Alpha+Gamma users `save 
dashboard as copy`.  For the users in your system that don't have save access, 
are they any of build-in roles, or any role that removes can_save_dash? thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to