williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189679344
##########
File path: superset/assets/src/dashboard/components/Header.jsx
##########
@@ -1,12 +1,18 @@
+/* eslint-env browser */
import React from 'react';
import PropTypes from 'prop-types';
-import { ButtonGroup, ButtonToolbar } from 'react-bootstrap';
+import {
+ DropdownButton,
+ MenuItem,
+ ButtonGroup,
+ ButtonToolbar,
+} from 'react-bootstrap';
import Controls from './Controls';
import EditableTitle from '../../components/EditableTitle';
import Button from '../../components/Button';
import FaveStar from '../../components/FaveStar';
-import SaveModal from './SaveModal';
+import SaveModal, { SAVE_TYPE_OVERWRITE } from './SaveModal';
Review comment:
I think `SAVE_TYPE_OVERWRITE ` should be moved into the dashboard constants
file, this defeats the purpose of having that file and centralizes all
constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
