williaster commented on a change in pull request #4979: Dashboard save button
URL:
https://github.com/apache/incubator-superset/pull/4979#discussion_r189679922
##########
File path: superset/assets/src/dashboard/components/SaveModal.jsx
##########
@@ -1,36 +1,40 @@
/* eslint-env browser */
import React from 'react';
import PropTypes from 'prop-types';
-import $ from 'jquery';
import { Button, FormControl, FormGroup, Radio } from 'react-bootstrap';
-import { getAjaxErrorMsg } from '../../modules/utils';
import ModalTrigger from '../../components/ModalTrigger';
import { t } from '../../locales';
import Checkbox from '../../components/Checkbox';
+export const SAVE_TYPE_OVERWRITE = 'overwrite';
Review comment:
see comment about moving these to constants file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
