[GitHub] williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations

[GitBox]

williaster commented on issue #4727: [webpack] setup lazy loading for all 
visualizations
URL: 
https://github.com/apache/incubator-superset/pull/4727#issuecomment-395662370
 
 
   Bundles are looking good in terms of maximum splitting/re-use. These images 
don't fully capture the picture for entry points (e.g., explorer, dashboard, 
sqllab) because every entry point "runtime" now actually consists of multiple 
scripts (for maximum sharing) [templates were updated accordingly]. 
   
   Rough empirical #s for DOM loaded, MB transferred, etc. match pretty close 
to what I posted 
[above](https://github.com/apache/incubator-superset/pull/4727#issuecomment-385615006),
 but the number of requests is now higher. I'm not sure this really matters if 
empirical load time + total MB transferred are still good, though.
   
   **before**
   <img width="1436" alt="screen shot 2018-06-07 at 11 14 14 pm" 
src="https://user-images.githubusercontent.com/4496521/41142155-843db260-6aa9-11e8-8861-f06dae753e20.png";>
   
   <img width="348" alt="screen shot 2018-06-07 at 11 14 05 pm" 
src="https://user-images.githubusercontent.com/4496521/41142165-9112162a-6aa9-11e8-8308-a69f53f2c75a.png";>
   
   
   **after webpack 4 + splitchunks**
   <img width="1436" alt="screen shot 2018-06-07 at 10 50 00 pm" 
src="https://user-images.githubusercontent.com/4496521/41142149-802906fc-6aa9-11e8-8958-c3575681fb43.png";>
   
   <img width="870" alt="screen shot 2018-06-07 at 11 14 50 pm" 
src="https://user-images.githubusercontent.com/4496521/41142179-97dc6028-6aa9-11e8-9335-9f44d84fe3d6.png";>
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org