williaster commented on issue #4727: [webpack] setup lazy loading for all visualizations URL: https://github.com/apache/incubator-superset/pull/4727#issuecomment-396430715 I found and resolved an issue where the `dynamic-import-node` babel transpilation plugin broke webpack's bundle splitting capability ([see comment here](https://github.com/webpack/webpack/issues/5703#issuecomment-363267093)), which threw off my perf testing numbers above. They are now updated and look slightly better. I also fixed the issue for updating visualizations promises and tested in explorer. @graceguo-supercat I also verified that switching between visualizations, or having multiple visualization of the same type does not result in new promises/requests. Should be ready to merge if tests pass after the rebase I just did.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
