codecov-io commented on issue #5240: [perf] add webpack 4 + SplitChunks + lazy 
load visualizations
URL: 
https://github.com/apache/incubator-superset/pull/5240#issuecomment-398209762
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5240?src=pr&el=h1)
 Report
   > Merging 
[#5240](https://codecov.io/gh/apache/incubator-superset/pull/5240?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/d7d5327ef7a0241d42df41b5612af900326e3110?src=pr&el=desc)
 will **decrease** coverage by `2.49%`.
   > The diff coverage is `40.84%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/5240/graphs/tree.svg?src=pr&token=KsB0fHcx6l&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/5240?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #5240     +/-   ##
   =========================================
   - Coverage   63.46%   60.96%   -2.5%     
   =========================================
     Files         261      260      -1     
     Lines       19845    19870     +25     
     Branches     1998     2002      +4     
   =========================================
   - Hits        12594    12114    -480     
   - Misses       7242     7747    +505     
     Partials        9        9
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/5240?src=pr&el=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...ts/src/visualizations/deckgl/layers/screengrid.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjcmVlbmdyaWQuanN4)
 | `0% <0%> (-38.19%)` | :arrow_down: |
   | 
[superset/assets/src/visualizations/time\_table.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy90aW1lX3RhYmxlLmpzeA==)
 | `0% <0%> (-16.82%)` | :arrow_down: |
   | 
[...ssets/src/visualizations/deckgl/layers/scatter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL3NjYXR0ZXIuanN4)
 | `0% <0%> (-27.84%)` | :arrow_down: |
   | 
[...et/assets/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlci5qc3g=)
 | `31.14% <0%> (ø)` | :arrow_up: |
   | 
[superset/assets/src/visualizations/markup.js](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9tYXJrdXAuanM=)
 | `0% <0%> (-26.67%)` | :arrow_down: |
   | 
[superset/assets/src/components/Loading.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xvYWRpbmcuanN4)
 | `87.5% <100%> (ø)` | :arrow_up: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `81.34% <100%> (ø)` | :arrow_up: |
   | 
[superset/assets/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jaGFydC9DaGFydC5qc3g=)
 | `56.52% <34.69%> (-8.48%)` | :arrow_down: |
   | 
[superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=)
 | `73.1% <81.81%> (+0.78%)` | :arrow_up: |
   | 
[...t/assets/src/visualizations/deckgl/layers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL2luZGV4Lmpz)
 | `0% <0%> (-100%)` | :arrow_down: |
   | ... and [44 
more](https://codecov.io/gh/apache/incubator-superset/pull/5240/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5240?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5240?src=pr&el=footer).
 Last update 
[d7d5327...04cc755](https://codecov.io/gh/apache/incubator-superset/pull/5240?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to