graceguo-supercat closed pull request #5217: [CRUD] disable user change slices
from dashboardmodelview
URL: https://github.com/apache/incubator-superset/pull/5217
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/views/core.py b/superset/views/core.py
index 0ceefe79fc..753c53878d 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -530,9 +530,9 @@ class DashboardModelView(SupersetModelView, DeleteMixin):
# noqa
list_columns = ['dashboard_link', 'creator', 'modified']
order_columns = ['modified']
edit_columns = [
- 'dashboard_title', 'slug', 'slices', 'owners', 'position_json', 'css',
+ 'dashboard_title', 'slug', 'owners', 'position_json', 'css',
'json_metadata']
- show_columns = edit_columns + ['table_names']
+ show_columns = edit_columns + ['table_names', 'slices']
search_columns = ('dashboard_title', 'slug', 'owners')
add_columns = edit_columns
base_order = ('changed_on', 'desc')
@@ -555,10 +555,6 @@ class DashboardModelView(SupersetModelView, DeleteMixin):
# noqa
'owners': _('Owners is a list of users who can alter the dashboard.'),
}
base_filters = [['slice', DashboardFilter, lambda: []]]
- add_form_query_rel_fields = {
- 'slices': [['slices', SliceFilter, None]],
- }
- edit_form_query_rel_fields = add_form_query_rel_fields
label_columns = {
'dashboard_link': _('Dashboard'),
'dashboard_title': _('Title'),
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
