mistercrunch commented on a change in pull request #5252: Use verbose name in
SQL Lab database dropdown
URL:
https://github.com/apache/incubator-superset/pull/5252#discussion_r197341488
##########
File path: superset/assets/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -155,7 +158,7 @@ class SqlEditorLeftBar extends React.PureComponent {
dataEndpoint={
'/databaseasync/api/' +
'read?_flt_0_expose_in_sqllab=1&' +
- '_oc_DatabaseAsync=database_name&' +
+ '_oc_DatabaseAsync=verbose_name&' +
Review comment:
I'm also unclear on how to make this work. If it was sql you'd ORDER BY
`COALESCE(verbose_name, database_name)` but being the FAB url mini-language I
can't think of a way to do this without changing FAB
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
