mistercrunch commented on a change in pull request #5252: Use verbose name in
SQL Lab database dropdown
URL:
https://github.com/apache/incubator-superset/pull/5252#discussion_r198201313
##########
File path: superset/assets/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -155,7 +158,7 @@ class SqlEditorLeftBar extends React.PureComponent {
dataEndpoint={
'/databaseasync/api/' +
'read?_flt_0_expose_in_sqllab=1&' +
- '_oc_DatabaseAsync=database_name&' +
+ '_oc_DatabaseAsync=verbose_name&' +
Review comment:
I think you could simply:
```
if not self.verbose_name:
self.verbose_name = self.name
```
But then you also need a db migration that does this on top of the on_add
and on_update events in the model view.
You could also:
* create a REST endpoint that does the sorting (not using FAB's api and
using custom endpoint instsead)
* add support to property sorting in FAB (that's probably hard)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
