[GitHub] williaster opened a new pull request #5293: fix sqllab css, fix double AddSliceCard margin and drag border

[GitBox]

williaster opened a new pull request #5293: fix sqllab <Loading /> css, fix 
double AddSliceCard margin and drag border
URL: https://github.com/apache/incubator-superset/pull/5293
 
 
   This PR fixes the following UI issues spotted in the new dashboard builder:
   
   - removes red from cached data visual indicator and adds a label for the 
last-fetched time
     **before**
     <img width="200" 
src="https://user-images.githubusercontent.com/4496521/41939826-bf819124-794b-11e8-8966-0c0428662547.png";>
   
     **after**
     <img width="150" 
src="https://user-images.githubusercontent.com/4496521/41939830-c4761240-794b-11e8-8d90-c5183eb8d377.png";>
     <img width="200" 
src="https://user-images.githubusercontent.com/4496521/41939831-c48ea346-794b-11e8-8193-fcd9fcf1c815.png";>
   
   - fixes css for SQL lab `<Loading />` instance
     **before**
     <img width="400" 
src="https://user-images.githubusercontent.com/4496521/41898158-15c84e92-78de-11e8-901f-9429e88025df.png";>
      <img width="400" 
src="https://user-images.githubusercontent.com/4496521/41940543-e5724f16-794d-11e8-8b44-dd6c213c2cc3.png";>
   
     **after**
     <img width="400" 
src="https://user-images.githubusercontent.com/4496521/41931872-33187f98-7934-11e8-8687-763195732bcd.png";>
   
     <img width="400" 
src="https://user-images.githubusercontent.com/4496521/41940562-f82de4c6-794d-11e8-9903-f65685f1e9e0.png";>
   
   - refactors `AddSliceCard` styles to remove double margin
     **before**
     <img width="400" alt="screen shot 2018-06-26 at 1 13 54 am" 
src="https://user-images.githubusercontent.com/4496521/41898219-42d7884e-78de-11e8-95ba-f763cbd1f33f.png";>
   
     **after**
     <img width="400" 
src="https://user-images.githubusercontent.com/4496521/41897737-fb3a5350-78dc-11e8-9324-b9288dd788a5.png";>
   
   - adds a check for `form_data` in the `Chart` component container to prevent 
throwing if `chart.form_data` is undefined
   
    @graceguo-supercat @john-bodley 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org