codecov-io commented on issue #5293: fix sqllab <Loading /> css, fix double AddSliceCard margin and drag border URL: https://github.com/apache/incubator-superset/pull/5293#issuecomment-400476173 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5293?src=pr&el=h1) Report > Merging [#5293](https://codecov.io/gh/apache/incubator-superset/pull/5293?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b0eee129e9d6bfb3582e5a1c060dbe142b3604b5?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5293?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5293 +/- ## ========================================= - Coverage 61.3% 61.3% -0.01% ========================================= Files 368 368 Lines 23453 23455 +2 Branches 2713 2715 +2 ========================================= + Hits 14378 14379 +1 - Misses 9063 9064 +1 Partials 12 12 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5293?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...et/assets/src/dashboard/components/SliceHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlci5qc3g=) | `39.39% <ø> (ø)` | :arrow_up: | | [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9kbmQvQWRkU2xpY2VEcmFnUHJldmlldy5qc3g=) | `59.09% <ø> (ø)` | :arrow_up: | | [...uperset/assets/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Tb3V0aFBhbmUuanN4) | `88.57% <ø> (ø)` | :arrow_up: | | [.../src/dashboard/components/BuilderComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9CdWlsZGVyQ29tcG9uZW50UGFuZS5qc3g=) | `64.86% <ø> (ø)` | :arrow_up: | | [...s/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9TbGljZUhlYWRlckNvbnRyb2xzLmpzeA==) | `37.25% <0%> (-0.49%)` | :arrow_down: | | [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9VbmRvUmVkb0tleWxpc3RlbmVycy5qc3g=) | `44% <0%> (-1.84%)` | :arrow_down: | | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29tcG9uZW50cy9ncmlkQ29tcG9uZW50cy9DaGFydC5qc3g=) | `82.71% <100%> (ø)` | :arrow_up: | | [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `84.84% <100%> (+0.31%)` | :arrow_up: | | [superset/assets/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5293/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvY29udGFpbmVycy9DaGFydC5qc3g=) | `95% <50%> (-5%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5293?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5293?src=pr&el=footer). Last update [b0eee12...345f83f](https://codecov.io/gh/apache/incubator-superset/pull/5293?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
