mahendra commented on issue #5294: Scheduled email reports for Slices / Dashboards URL: https://github.com/apache/incubator-superset/pull/5294#issuecomment-402574997 @mistercrunch I did consider the idea of URLs for the image and embedding it within mails. However, I decided against it for the following reasons 1. Generating the image (using a webdriver) was an expensive operation (CPU/Memory). I thought it would be better to generate it once in the background and send it off to multiple recipients in one shot. We could cache the URLs and reduce the hit on the servers. 2. As you noted - VPN limitations. We have such a setup, but we have a large mobile sales team which will appreciate full delivery of the data for quick reference. (mobile device VPN is a pain) 3. We also plan to send out mails to external entities, who will not have access to our mobile setup. I however do like the embedded URL approach to prevent accidental forwards of internal reports to external folks :-) I agree on having a both approaches. The current approach is easy to extend. * The celery jobs generate the images and store/cache them (for a period of time) * The emails contain the links or blobs (based on a config) * If someone hits the URL and the image does not exist / has expired, we fire off a celery job and generate it. I can work on this in a future ticket (this issue - https://github.com/apache/incubator-superset/issues/623)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
