graceguo-supercat commented on a change in pull request #5360: [dashboard] Fix
save issue at Force_V2_Edit mode
URL:
https://github.com/apache/incubator-superset/pull/5360#discussion_r200800445
##########
File path: superset/assets/src/dashboard/deprecated/v1/components/Header.jsx
##########
@@ -43,25 +43,11 @@ class Header extends React.PureComponent {
showV2PromptModal: props.dashboard.promptV2Conversion,
};
this.toggleShowV2PromptModal = this.toggleShowV2PromptModal.bind(this);
- this.handleConvertToV2 = this.handleConvertToV2.bind(this);
+ this.handleConvertToV2 = props.handleConvertToV2.bind(this);
}
handleSaveTitle(title) {
this.props.updateDashboardTitle(title);
}
- handleConvertToV2(editMode) {
Review comment:
here, `handleConvertToV2` is refactored out into Dashboard component, since
this function is called from both Dashboard and Header component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
