graceguo-supercat commented on a change in pull request #5360: [dashboard] Fix
save issue at Force_V2_Edit mode
URL:
https://github.com/apache/incubator-superset/pull/5360#discussion_r200800676
##########
File path: superset/views/core.py
##########
@@ -2169,6 +2169,8 @@ def dashboard(self, dashboard_id):
else:
dashboard_view = 'v1'
prompt_v2_conversion = not force_v1
+ if force_v2_edit:
+ dash_edit_perm = False
Review comment:
this line disallow owner to save original v1 dashboard. `Edit dashboard`
button in Header controls used `dash_save_perm`, which is not affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
