betodealmeida commented on a change in pull request #5524: A tagging system for
dashboards, charts and queries
URL:
https://github.com/apache/incubator-superset/pull/5524#discussion_r206589131
##########
File path: superset/assets/src/explore/components/ExploreChartHeader.jsx
##########
@@ -32,9 +41,22 @@ const propTypes = {
};
class ExploreChartHeader extends React.PureComponent {
+ constructor(props) {
+ super(props);
+
+ this.fetchTags = fetchTags.bind(this, 'chart', props.chart.id, false);
Review comment:
But here I'm binding more than just `this`, I'm actually building a partial
function that can be passed to `<ObjectTags />`. From what I understand
`autobind` will only bind `this`, no?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
