betodealmeida commented on a change in pull request #5524: A tagging system for
dashboards, charts and queries
URL:
https://github.com/apache/incubator-superset/pull/5524#discussion_r207343234
##########
File path: superset/models/tags.py
##########
@@ -0,0 +1,233 @@
+# -*- coding: utf-8 -*-
+# pylint: disable=no-init
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+import enum
+
+from flask_appbuilder import Model
+from sqlalchemy import Column, Enum, ForeignKey, Integer, String
+from sqlalchemy.orm import relationship, sessionmaker
+from sqlalchemy.orm.exc import NoResultFound
+
+from superset.models.helpers import AuditMixinNullable
+
+
+Session = sessionmaker(autoflush=False)
+
+
+class TagTypes(enum.Enum):
Review comment:
Yeah, I think even in 2.7.3. There's also a backport `enum34` which we could
add as an optional dependency, something like:
```python
# setup.py
if sys.version_info < (2, 7, 3):
deps.append('enum34')
```
And I'm +1 on moving towards newer versions. I think when developing
libraries it's important to be more conservative, but for applications it's
fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
